Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing uns array returns error instead of None #832

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

kaloster
Copy link
Contributor

@kaloster kaloster commented Mar 15, 2024

This is a fix for get_spatial() to return None instead of e when uns array is missing

Tests:

  • Pulled same unaltered dataset from s3 (spatial without uns)

  • Ran locally with spatial embedding

  • Tested altered (spatial with uns)

  • Ran locally with spatial embedding

Screenshot 2024-03-15 at 6 07 10 PM Screenshot 2024-03-15 at 6 07 28 PM

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 76.57%. Comparing base (2b0f86e) to head (b1593f4).

Files Patch % Lines
server/dataset/dataset.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #832   +/-   ##
=======================================
  Coverage   76.57%   76.57%           
=======================================
  Files          88       88           
  Lines        6994     6994           
=======================================
  Hits         5356     5356           
  Misses       1638     1638           
Flag Coverage Δ
frontend 76.57% <33.33%> (ø)
javascript 76.57% <33.33%> (ø)
smokeTest ∅ <ø> (?)
unitTest 76.57% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaloster kaloster changed the title fix: missing uns array returns error instead on None fix: missing uns array returns error instead of None Mar 15, 2024
@kaloster kaloster merged commit f157e0c into main Mar 15, 2024
7 checks passed
@kaloster kaloster deleted the kaloster/missing-uns-error-fix branch March 15, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants