Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 84 Do not cache index.html #86

Merged
merged 2 commits into from
Sep 24, 2021
Merged

Conversation

tihuan
Copy link
Contributor

@tihuan tihuan commented Sep 24, 2021

Reviewers

Functional:

Readability:

Proof that it's working locally 🙆‍♂️ Thank you!

Screen Shot 2021-09-24 at 10 09 31 AM


Changes

  • add
  • remove
  • modify

@tihuan tihuan requested a review from MDunitz September 24, 2021 17:11
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #86 (957fcb7) into main (e807dca) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   71.83%   71.83%           
=======================================
  Files         126      126           
  Lines       10084    10084           
=======================================
  Hits         7244     7244           
  Misses       2840     2840           
Flag Coverage Δ
frontend 71.83% <100.00%> (ø)
javascript 71.83% <100.00%> (ø)
unitTest 71.83% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/app/app.py 76.30% <100.00%> (ø)
app/app.py 76.30% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e807dca...957fcb7. Read the comment docs.

@tihuan tihuan enabled auto-merge (squash) September 24, 2021 17:20
@tihuan tihuan requested a review from ebezzi September 24, 2021 17:53
Copy link
Contributor

@MDunitz MDunitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tihuan tihuan merged commit 8bc3e06 into main Sep 24, 2021
@tihuan tihuan deleted the thuang-84-no-store-index-html branch September 24, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants