-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unit tests and slight refactor #877
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #877 +/- ##
==========================================
+ Coverage 76.58% 77.27% +0.69%
==========================================
Files 88 90 +2
Lines 7020 7024 +4
==========================================
+ Hits 5376 5428 +52
+ Misses 1644 1596 -48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for adding the tests, Ronen! Some discussion comments PTAL thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work, @kaloster 🙏 🔥 !! Thanks so much for the thorough tests!!
Added 2 unit tests:
test_uns_no_metadata_get
- for dataset withoutuns
array or spatialtest_uns_metadata_get
- for dataset withuns
array and spatialSlight refactor to extract metadata helper functions to a dedicated utils file