-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add e2e tests for cellguide cxgs and related features #902
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
==========================================
- Coverage 77.47% 77.27% -0.21%
==========================================
Files 88 45 -43
Lines 6856 3512 -3344
==========================================
- Hits 5312 2714 -2598
+ Misses 1544 798 -746
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! Thanks for adding comprehensive tests, Alec 🙏 Some v minor comments otherwise LGTM 🔥 !!
client/__tests__/e2e/e2e.test.ts
Outdated
@@ -101,6 +104,143 @@ const testURLs = { | |||
"super-cool-spatial.cxg": pageURLSpatial, | |||
}; | |||
|
|||
describe(`Testing CellGuideCXG at ${pageURLCellGuide}`, () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should put the CellGuideCXG test in its own test file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how to config playwright to run the separate file - if you think it's important, perhaps you could commit it to this branch so I can learn? 👼
b9cde61
to
87f4ec1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMMM! Thanks so much again, Alec 👏 🙏 🔥
Adding E2E tests for the following interactions:
Added a test fixture in the
cellguide-cxgs/
path to setisCellGuideCxg
equal to true.Note that because we now have test coverage for the new categorical label behaviors, I removed the isCellGuideCxg feature flag from it. Now all explorer instances will benefit from the improved UX. Namely, the improvements are:
Also, to reduce the size of the new test fixture added (
example.cxg
), I set the gene expression tiledb arraysXr
andXc
to have no data in it. This is fine as none of the cellguide-specific tests require gene expression data.