Devfile Commands support #46
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
9 similar comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Signed-off-by: Artem Zatsarynnyi <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
2 similar comments
This comment was marked as outdated.
This comment was marked as outdated.
|
Pull Request images published ✨ |
azatsarynnyy
changed the title
azatsarynnyy
requested review from
RomanNikitenko,
vzhukovs and
benoitf
as code owners
azatsarynnyy
changed the title
|
Code looks good but I'm not able to test on the dogfooding instance (not related to this PR) |
|
|
||
| command = command + ` --component ${component}`; | ||
| const execution = new vscode.ShellExecution(command, { cwd: expandEnvVariables(workdir) }); | ||
| const task = new vscode.Task(kind, vscode.TaskScope.Workspace, name, 'eclipse-che.commands', execution); |
There was a problem hiding this comment.
probably it makes sense to use a short type for che commands
but up to you
There was a problem hiding this comment.
Good point.
Actually, it's not a task type, but a task source. I don't know what this string affects except this list. The documentation just says Is presented in the user interface.
Usually, an extension's publisher and name are used there, exactly how it's defined in the extension's package.json.
I've shortened it to che. Just pushed. Let's see how it looks and works, once the PR image is ready.
There was a problem hiding this comment.
Now, it looks much better:
Signed-off-by: Artem Zatsarynnyi <[email protected]>
|
Is it expected to have an ability to edit I'm asking because I tried to do it and found that it's impossible to execute a configured Screen.Recording.2022-06-02.at.18.23.49.mov
|
No. Currently, just running a task detected in the user's Devfile. |
|
Pull Request images published ✨ |
|
Thank you @RomanNikitenko for your review and testing. |
Signed-off-by: Artem Zatsarynnyi [email protected]
The PR adds the Che-Commands extension. It detects the Commands defined in a Devfile and represents them as VS Code Tasks. The environment variables substitution is supported for the
exec.workingDirproperty.The PR closes eclipse-che/che#21030
How to test
https://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com/#https://github.com/azatsarynnyy/java-spring-petclinic/tree/devfilev2
taskshortcut and choose achetask type.prepare-databasecommand. It's running in themariadbcomponent. See the output.maven-buildcommand. It's running in thetoolscomponent. See the output.