-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS backdrop-filter
affects photo gallery scrolling animations FPS (+ other places)
#212
Comments
backdrop-filter
affects animations FPSbackdrop-filter
affects photo gallery scrolling animations FPS
Gallery fix worked 👍
Might be a good idea to double-check every place with this filter It will really improve users experience. Now it is lagging even on my Macbook M1 Air (not everyone can notice that, but still) @cheeaun if you don't have time to fix this, just let me know what is resolution strategy for those cases, and i will try to make PR |
@Alex0007 is this a different bug? I can understand if this lags on a phone but it seems weird that it's lagging on a desktop (especially on M1 😲). Is it possible if you can check/pinpoint if the blur is the main cause for this case, maybe have a user-style to disable all backdrop-filter styles 🙏 |
It is same kind of bug, but in different place (now in "play" overlay above videos, which also has that blur style)
It's not that noticeable on notebook. On the phone you can see micro freezes when blurred element appear on the screen. While on notebook smooth scrolling stops being smooth. You might think I'm crazy, but this performance problems are really blocking me from using Phanpy on the phone. Most annoying bug was gallery one and now it's fixed, but maybe it's worth to fix remaining places to get ideal performance
Now gallery swipes perform great, and I have noticed that before looking into commits history. So yes, it is the case. Not sure every blur in codebase dips performance. For example header blur is fine, as well as text blur in spoilers (but spoiler with additional elements, like pictures or polls is lagging too) |
backdrop-filter
affects photo gallery scrolling animations FPSbackdrop-filter
affects photo gallery scrolling animations FPS (+ other places)
Closing for now until i get more evidence of drops |
Describe the bug
A clear and concise description of what the bug is.
Swiping photos is unpleasant experience due to FPS drops
To Reproduce
Steps to reproduce the behavior:
P.S. you can hide control elements, by tapping photo. After hiding – FPS is no longer dropping (because .plain2, plain3 class elements are hidden)
Comment out these two styles and gallery animation framerate will dramatically increase.
I guess this happens because of
transparent
+ blur() on moving photos, which consumes a lot of CPU on each frameRef: https://github.com/cheeaun/phanpy/blob/main/src/index.css#L199
Smartphone (please complete the following information):
Additional context
I have checked locally, that removing those
backdrop-filter
solves problem, but i'm not a frontend guy, so i don't know how to correctly replace them with somewhat similarThe text was updated successfully, but these errors were encountered: