Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests #128

Closed
chris-rock opened this issue Oct 27, 2016 · 2 comments
Closed

Add unit tests #128

chris-rock opened this issue Oct 27, 2016 · 2 comments
Milestone
2.0

Comments

@chris-rock
Copy link
Contributor

#122 re-added support for compliance profile upload. This PR has not covered the unit tests and we should add enable them for 2.0 release.
@chris-rock chris-rock added this to the 2.0 milestone Oct 27, 2016
@chris-rock chris-rock mentioned this issue Oct 27, 2016
Merged
@jeremymv2
Copy link
Contributor

jeremymv2 commented Oct 27, 2016 •
edited
Loading

@chris-rock This is what the previous upload unit tests looked like: https://github.com/jeremymv2/audit/blob/7c1930a46dcda3aa0b16e0ae2749d8b3f9a5edd5/spec/unit/recipes/upload_spec.rb

@chris-rock chris-rock changed the title Add unit tests for profile upload Add unit tests Oct 27, 2016
@chris-rock
Copy link
Contributor Author

This should clean up all unit tests:

  • for profile upload

We should have a separate file for component and visibility should move from helpers as well.

This was referenced Oct 27, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@chris-rock @jeremymv2