Add unit tests #131
Merged
Add unit tests #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjeffrey
force-pushed
the
vj/add-tests
branch
2 times, most recently
from
8f4db04 to
0cbbe69
Compare
chris-rock
reviewed
Oct 28, 2016
| @@ -15,15 +15,16 @@ def report | |||
| interval_enabled = node['audit']['interval']['enabled'] | |||
| interval_time = node['audit']['interval']['time'] | |||
| report_file = node['audit']['output'] | |||
| test_array = node['audit']['profiles'] | |||
There was a problem hiding this comment.
Is profiles maybe a better name? I was thinking about an array of single tests first
| @@ -20,6 +20,9 @@ | |||
| require 'spec_helper' | |||
There was a problem hiding this comment.
We may should rename the spec to visibility_spec.rb. Do we intent to add more specs for other reporters?
There was a problem hiding this comment.
yup, i'll move everything to its own spot
vjeffrey
force-pushed
the
vj/add-tests
branch
from
0cbbe69 to
1d8dbe8
Compare
vjeffrey
commented
Oct 28, 2016
| require_relative '../../../libraries/collector_classes' | ||
|
|
||
| # TODO: can't get this to work: `# ./libraries/collector_classes.rb:251:in `node_info'` | ||
| # need to figure out how to mock the run context |
There was a problem hiding this comment.
:( can't figure out how to mock the run context..is there another way around this?
There was a problem hiding this comment.
The solution is the removal of the run context. I'll work on a PR to cover that
Signed-off-by: Victoria Jeffrey <[email protected]>
vjeffrey
force-pushed
the
vj/add-tests
branch
from
1d8dbe8 to
ca6cf4d
Compare
|
This fixes #128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds more testing!
A few of them I couldn't get to work correctly....