do not hand over run context into reporter #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjeffrey
reviewed
Oct 28, 2016
| def send_report(reporter, server, user) | ||
| Chef::Log.info "Reporting to #{reporter}" | ||
|
|
||
| # TODO: harmonize reporter interface | ||
| if reporter == 'chef-visibility' | ||
| Collector::ChefVisibility.new(entity_uuid, run_id, run_context.node.name).send_report | ||
| Collector::ChefVisibility.new(entity_uuid, run_id, gather_nodeinfo).send_report | ||
|
|
There was a problem hiding this comment.
i think only node name was being sent to viz, which is why the tests are complaining
|
🌟 🎉 👍 yay!!!!! viz tests are breaking cause it only expects the node name, but +:1: once that's fixed! :) |
Signed-off-by: Christoph Hartmann <[email protected]>
chris-rock
force-pushed
the
chris-rock/run_context
branch
from
1e52edd to
6484233
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.