Add report summary output to chef logs #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
force-pushed
the
chris-rock/chef-log-summary
branch
from
9695245 to
f6b7a9e
Compare
chris-rock
commented
Apr 26, 2017
| unless r.nil? && ['json-min', 'json'].include(opts['format']) | ||
| time = 0 | ||
| time = r[:statistics][:duration] unless r[:statistics].nil? | ||
| passed_controls = r[:controls].select { |c| c[:status] == 'passed' }.size |
There was a problem hiding this comment.
Ah, I was running into the issue that controls are available in full reports, too. See inspec/inspec#1564. Since this is deprecated, we need to adapt this implementation.
Signed-off-by: Christoph Hartmann <[email protected]>
chris-rock
force-pushed
the
chris-rock/chef-log-summary
branch
from
f6b7a9e to
1822824
Compare
|
Thank you for improving this calculation, great improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a info log message to chef client runs. This makes it a lot easier to see if InSpec was properly executed. A sample output looks like:
Issues Resolved
It may address #207