Deprecate collector attribute
#211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
changed the title
collector attributecollector attribute
chris-rock
force-pushed
the
chris-rock/deprecate-collector-naming
branch
from
dad20fb to
6b07567
Compare
chris-rock
changed the title
collector attributecollector attribute
Signed-off-by: Christoph Hartmann <[email protected]>
chris-rock
force-pushed
the
chris-rock/deprecate-collector-naming
branch
from
6b07567 to
0416d82
Compare
arlimus
suggested changes
Apr 26, 2017
README.md
Outdated
| @@ -5,6 +5,21 @@ The `audit` cookbook allows you to run InSpec profiles as part of a Chef Client | |||
|
|
|||
| Version 2.0 of the audit cookbook is based on an idea from [Michael Hedgpeth](https://github.com/chef-cookbooks/audit/issues/70). Under the hood it uses [Chef handler](https://docs.chef.io/handlers.html) instead of Chef resources now. | |||
|
|
|||
| Note: With version 3.1.0, we are deprecating the use `collector` attribute and use the term `reporter`. The following | |||
There was a problem hiding this comment.
slight phrasing improvement suggestion:
Note: With version 3.1.0 the use of the `collector` attribute is deprecated. Please use `reporter` instead. The `collector` attribute will be removed in the next major version.
Signed-off-by: Christoph Hartmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the name of the
collectorattribute toreporter. This is a non-breaking change, because the fallback has been implemented already: https://github.com/chef-cookbooks/audit/blob/master/libraries/helper.rb#L128-L136Fixes #205