-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readme updates #223
readme updates #223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition @jeremymv2 Should me make this part of the markdown readme?
config_matrix.html
Outdated
<th>Fetch From Compliance via Chef Server</th> | ||
<td> <!-- Fetch from Compliance via Chef Server : Report Directly to Compliance --> | ||
<pre> | ||
['audit']['reporter'] = 'chef-compliance' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should be chef-server-compliance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
58 <td> <!-- Fetch from Compliance via Chef Server : Report Directly to Compliance -->
59 <pre>
60 ['audit']['reporter'] = 'chef-compliance'
61 ['audit']['fetcher'] = 'chef-server'
62 ['audit']['server'] = 'https://compliance-server.test/api'
63 ['audit']['refresh_token' OR 'token'] = '..'
64 ['audit']['owner'] = 'Owner/Org'
65
66 Compliance Integrated w/ Chef Server
67 </pre>
68 </td>
Hey @chris-rock I think it's correct as-is. That section of config is handling: fetching from Compliance via Chef Server (Integration) and report directly to Compliance. The fetcher
is therefore chef-server (to fetch via the Integration) and reporter
is chef-compliance to report directly to Compliance - not via Chef-Server Integration.
config_matrix.html
Outdated
</td> | ||
<td> <!-- Fetch from Compliance via Chef Server : Report Directly to Automate --> | ||
<pre> | ||
['audit']['reporter'] = 'chef-automate' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chef-server-automate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
69 <td> <!-- Fetch from Compliance via Chef Server : Report Directly to Automate -->
70 <pre>
71 ['audit']['reporter'] = 'chef-automate'
72 ['audit']['fetcher'] = 'chef-server'
73 ['audit']['server'] = 'https://compliance-server.test/api'
74 ['audit']['refresh_token' OR 'token'] = '..'
75 ['audit']['owner'] = 'Owner/Org'
76
77 Compliance Integrated w/ Chef Server
78
79 client.rb:
80 data_collector['server_url'] = 'https://automate-server.test/data-collector/v0/'
81 data_collector['token'] = '..'
82 </pre>
83 </td>
Again, I think it's correct as-is. use fetcher=chef-server to fetch via Integration, use report=chef-automate to report Directly to Automate, not via chef-server integration.
@chris-rock I can see what it looks like with the html table embedded into the README.md markdown. My concern initially was that it may be too wide and look strange. I'll see what happens and paste a screenshot. |
If we have markdown, we can also create a separate docs dir if required. This would allow us to embed this in our inspec page eventually. |
The new format of the table in the README.md can be seen here: https://github.com/jeremymv2/audit-docs/blob/master/grid3.md |
3c73263
to
63208a6
Compare
Signed-off-by: Jeremy J. Miller <[email protected]>
63208a6
to
2b4afb7
Compare
@chris-rock I think this is better now because it is all contained in the README. I believe these changes make the documentation more streamlined and easier to consume. Can you review again please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition @jeremymv2
Signed-off-by: Jeremy J. Miller [email protected]
Description
This is an attempt to make it easier for consumers of the cookbook to understand the necessary config options for their desired scenario.
The config_matrix.html can be viewed here
Issues Resolved
Check List