Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure json file outputs a json file #247

Merged
merged 1 commit into from
Jun 19, 2017
Merged

ensure json file outputs a json file #247

merged 1 commit into from
Jun 19, 2017

Conversation

chris-rock
Copy link
Contributor

@chris-rock chris-rock commented Jun 19, 2017 •
edited
Loading

Signed-off-by: Christoph Hartmann [email protected]

Description

follow-up PR to add a test for #246

@chris-rock
ensure json file outputs a json file
e883699 
Signed-off-by: Christoph Hartmann <[email protected]>
alexpop
alexpop approved these changes Jun 19, 2017
View reviewed changes
Copy link
Contributor

@alexpop alexpop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are great, thanks!

@chris-rock chris-rock merged commit c329aa7 into master Jun 19, 2017
@chris-rock chris-rock deleted the chris-rock/json-spec-test branch June 19, 2017 12:46
@chris-rock chris-rock self-assigned this Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexpop alexpop alexpop approved these changes

Assignees

@chris-rock chris-rock

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-rock @alexpop