Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTT: wrong counting for sampler valid causing deadlock #90

Open
mojtaba-bisheh opened this issue Feb 10, 2025 · 0 comments
Open

NTT: wrong counting for sampler valid causing deadlock #90

mojtaba-bisheh opened this issue Feb 10, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@mojtaba-bisheh
Copy link
Collaborator

If sampler valid de-asserts at data beat number 63 it can cause a deadlock, where the computation never finishes.
Here is the response from the designer:

This is a bug. I see in the waves that, sampler_valid goes low on the very last read. In that case, since data is not valid, NTT should wait for sampler_valid to go high again and then read, execute and write. But in this case, since the read counter is already updated, it thinks that it already saw the last data whereas the write fsm is stuck because it only counted 63 writes instead of 64.

ntt_top_never_leaves_busy3.fsdb.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants