Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Remove explicit pom scm from build.sbt #2004

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Remove explicit pom scm from build.sbt #2004

merged 1 commit into from
Dec 4, 2020

Conversation

jackkoenig
Copy link
Contributor

@jackkoenig jackkoenig commented Dec 4, 2020 •
edited
Loading

This is now set by sbt-ci-release

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • [NA] Did you update the FIRRTL spec to include every new feature/behavior?
  • [NA] Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • [NA] Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • release fix

API Impact

No impact

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@jackkoenig
Remove explicit pom scm from build.sbt
a24c9f1 
This is now set by sbt-ci-release
@jackkoenig jackkoenig added this to the 1.2.X milestone Dec 4, 2020
@jackkoenig jackkoenig requested a review from chick December 4, 2020 19:59
chick
chick approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@chick chick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jackkoenig jackkoenig added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Dec 4, 2020
@mergify mergify bot merged commit 862aaec into master Dec 4, 2020
mergify bot pushed a commit that referenced this pull request Dec 4, 2020
@jackkoenig
Remove explicit pom scm from build.sbt (#2004)
819a2b2 
This is now set by sbt-ci-release

(cherry picked from commit 862aaec)

# Conflicts:
#	build.sbt
@mergify mergify bot mentioned this pull request Dec 4, 2020
Merged
mergify bot pushed a commit that referenced this pull request Dec 4, 2020
@jackkoenig
Remove explicit pom scm from build.sbt (#2004)
6b58c1e 
This is now set by sbt-ci-release

(cherry picked from commit 862aaec)
@mergify mergify bot mentioned this pull request Dec 4, 2020
Merged
mergify bot pushed a commit that referenced this pull request Dec 4, 2020
@jackkoenig
Remove explicit pom scm from build.sbt (#2004)
3b8f902 
This is now set by sbt-ci-release

(cherry picked from commit 862aaec)
@mergify mergify bot mentioned this pull request Dec 4, 2020
Merged
@mergify mergify bot added the Backported This PR has been backported to marked stable branch label Dec 4, 2020
mergify bot added a commit that referenced this pull request Dec 4, 2020
@mergify @jackkoenig
Remove explicit pom scm from build.sbt (#2004) (#2006)
492df52 
This is now set by sbt-ci-release

(cherry picked from commit 862aaec)

Co-authored-by: Jack Koenig <[email protected]>
mergify bot added a commit that referenced this pull request Dec 4, 2020
@mergify @jackkoenig
Remove explicit pom scm from build.sbt (#2004) (#2007)
6f5a347 
This is now set by sbt-ci-release

(cherry picked from commit 862aaec)

Co-authored-by: Jack Koenig <[email protected]>
mergify bot added a commit that referenced this pull request Mar 20, 2021
@mergify @jackkoenig
Remove explicit pom scm from build.sbt (bp #2004) (#2005)
3988b51 
* Remove explicit pom scm from build.sbt (#2004)

This is now set by sbt-ci-release

(cherry picked from commit 862aaec)

# Conflicts:
#	build.sbt

* Resolve conflicts

Co-authored-by: Jack Koenig <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@jackkoenig jackkoenig deleted the remove-scm branch March 26, 2021 23:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chick chick chick approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported to marked stable branch Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. release issue
Projects
None yet
Milestone
1.2.x
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkoenig @chick