This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
ConstantPropagation: make RemoveValidIf an optional dependency #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows ConstantPropagation to be used in cases where ValidIfs need to be maintained, e.g., in the formal backend.
seldridge
approved these changes
Jan 11, 2021
There was a problem hiding this comment.
This makes sense. There isn't a requirement that ConstantPropagation has to have RemoveValidIf. I expect this was like this just because it produce the "correct" ordering.
Note: it may be more accurate to express this as an invalidation from RemoveValidIf if the relationship is one of RemoveValidIf exposing more work for ConstantPropagation.
jackkoenig
added
Please Merge
azidar
added
the
Please Merge
jackkoenig
added
Please Merge
mergify bot
pushed a commit
that referenced
this pull request
Feb 1, 2021
This allows ConstantPropagation to be used in cases where ValidIfs need to be maintained, e.g., in the formal backend. Co-authored-by: Adam Izraelevitz <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit ad0fd65) # Conflicts: # src/main/scala/firrtl/transforms/ConstantPropagation.scala
mergify bot
pushed a commit
that referenced
this pull request
Feb 1, 2021
This allows ConstantPropagation to be used in cases where ValidIfs need to be maintained, e.g., in the formal backend. Co-authored-by: Adam Izraelevitz <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit ad0fd65) # Conflicts: # src/main/scala/firrtl/transforms/ConstantPropagation.scala
mergify bot
pushed a commit
that referenced
this pull request
Feb 1, 2021
This allows ConstantPropagation to be used in cases where ValidIfs need to be maintained, e.g., in the formal backend. Co-authored-by: Adam Izraelevitz <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit ad0fd65)
mergify
bot
added
the
Backported
mergify bot
added a commit
that referenced
this pull request
Feb 1, 2021
#2066) This allows ConstantPropagation to be used in cases where ValidIfs need to be maintained, e.g., in the formal backend. Co-authored-by: Adam Izraelevitz <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit ad0fd65) Co-authored-by: Kevin Laeufer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows ConstantPropagation to be used in cases where ValidIfs need to be maintained, e.g., in the formal backend.
First step towards: #2011
Contributor Checklist
Type of Improvement
API Impact
This allows the
ConstantPropagationpass to be scheduled withoutRemoveValidIf.Backend Code Generation Impact
RemoveValidIfwill still be included in the default firrtl compiler.Desired Merge Strategy
Reviewer Checklist (only modified by reviewer)
Please Merge?