Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Restore scalafmt CI check #2047

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Restore scalafmt CI check #2047

merged 2 commits into from
Jan 20, 2021

Conversation

jackkoenig
Copy link
Contributor

@jackkoenig jackkoenig commented Jan 19, 2021

Fix scalafmtCheckAll failures that snuck through.

Backporting to only 1.4.x because it is the only stable branch with scalafmt.

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • [NA] Did you update the FIRRTL spec to include every new feature/behavior?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • [NA] Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • bug fix

API Impact

No impact

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

Fix scalafmtCheckAll failures that snuck through
@jackkoenig jackkoenig added this to the 1.4.x milestone Jan 19, 2021
@jackkoenig jackkoenig added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Jan 20, 2021
@jackkoenig
Copy link
Contributor Author

Mergify gives you a red X when it isn't allowed to merge 🙈

@jackkoenig jackkoenig merged commit 6d8e904 into master Jan 20, 2021
@mergify mergify bot added the Backported This PR has been backported to marked stable branch label Jan 20, 2021
jackkoenig added a commit that referenced this pull request Jan 20, 2021
Fix scalafmtCheckAll failures that snuck through
(cherry picked from commit 6d8e904)
@jackkoenig jackkoenig deleted the restore-scalafmt-check branch January 20, 2021 01:05
jackkoenig added a commit that referenced this pull request Jan 20, 2021
Fix scalafmtCheckAll failures that snuck through
(cherry picked from commit 6d8e904)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Backported This PR has been backported to marked stable branch Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants