Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Replace hard coded line separators with system specific ones in SMT checker #2281

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

yqszxx
Copy link
Contributor

@yqszxx yqszxx commented Jun 23, 2021

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • [NA] Did you update the FIRRTL spec to include every new feature/behavior?
  • [NA] Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • [NA] Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • bug fix

API Impact

None.

Backend Code Generation Impact

None.

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@CLAassistant
Copy link

CLAassistant commented Jun 23, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@sequencer sequencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sequencer sequencer added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Jun 23, 2021
@ekiwi
Copy link
Contributor

ekiwi commented Jun 23, 2021

Please run scalafmtAll

@yqszxx yqszxx force-pushed the fix-smt-linesep branch from 9caa6e3 to 2563e48 Compare July 7, 2021 02:48
@yqszxx yqszxx force-pushed the fix-smt-linesep branch from 2563e48 to 3dbb01b Compare July 7, 2021 02:53
@mergify mergify bot merged commit 61b51e2 into chipsalliance:master Jul 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants