This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses virtual method .getBytesBuffered: Iterable[Array[Byte]] to optimize
file emission.
This is intended to enable faster annotation serialization. In particular this will be used to make
.fir
emission from Chisel support > 2 GiB.fir
files. Currently. Chisel serializes the.fir
to aString
which has a max size of 2 GiB. We could use theCustomFileEmission
API but it is 9-12x slower using justIterable[Byte]
so this PR is intended to make it much faster via buffering.Contributor Checklist
Type of Improvement
API Impact
Expands the API with a new subclass of
CustomFileEmission
calledBufferedCustomFileEmission
Backend Code Generation Impact
No impact
Desired Merge Strategy
Release Notes
Introduce
BufferedCustomFileEmission
which enables Annotation writers to optimize serialization performance for their annotations.Reviewer Checklist (only modified by reviewer)
Please Merge
?