Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

ci: switch from container to Tabby OSS CAD Suite #2365

Merged
merged 2 commits into from
Sep 27, 2021

Conversation

ekiwi
Copy link
Contributor

@ekiwi ekiwi commented Sep 23, 2021

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you update the FIRRTL spec to include every new feature/behavior?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

API Impact

Backend Code Generation Impact

Desired Merge Strategy

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@ekiwi
Copy link
Contributor Author

ekiwi commented Sep 23, 2021

Just an experiment for now. Let's see how it goes.

@ekiwi
Copy link
Contributor Author

ekiwi commented Sep 23, 2021

Well this seems to work surprisingly well.

@ekiwi ekiwi marked this pull request as ready for review September 23, 2021 19:25
@ekiwi ekiwi mentioned this pull request Sep 23, 2021
14 tasks
@ekiwi ekiwi requested a review from jackkoenig September 27, 2021 17:31
@ekiwi ekiwi added this to the 1.5.0 milestone Sep 27, 2021
@ekiwi ekiwi requested a review from seldridge September 27, 2021 19:24
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am totally fine to try this. I'm nervous that there may be some weird unintended consequences that I'm not aware of. But... :shipit:

@ekiwi ekiwi merged commit a921e12 into chipsalliance:master Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants