This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
Make MemConf's MemPort serialization deterministic #2508
Merged
+29
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: MemConf serialization of MemPorts was not deterministic
and the ordering seems to have changed as we move projects to 2.13
Downstream project can be adversely affected by changes in ordering
This changes specifies as specific ordering that should be compatible with
the historically one.
Contributor Checklist
Type of Improvement
Code cleanup
API Impact
This change should preserve existing behavior that was changing as we continue to move to 2.13
Without this change downstream users for MemConf output could break
Backend Code Generation Impact
Verilog output should not be altered
Desired Merge Strategy
Squash and Merge
Release Notes
The order of MemPort fields in serialized MemConf is now guaranteed to be in the following order:
Reviewer Checklist (only modified by reviewer)
Please Merge
?