Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extra parameters to the from_pretrained method #14

Open
not-lain opened this issue Nov 27, 2024 · 3 comments
Open

add extra parameters to the from_pretrained method #14

not-lain opened this issue Nov 27, 2024 · 3 comments

Comments

@not-lain
Copy link
Contributor

I think we should update the from_pretrained method, for example, we can :

  • add a token parameter there and pass the token explicitly
  • revision parameter to load a tokenizer from a specific commit, pr or a branch.
  • others ...
@bhavnicksm
Copy link
Collaborator

Hey @not-lain,

Thanks for opening an issue (^-^)

Just wanted to confirm some things:

  • By token parameter, do you mean the hf_token?
  • As far as I know, Tokenizers rarely change over revisions. Do you see it being used in a specific tokenizer case that changes often?

Thanks!

@not-lain
Copy link
Contributor Author

not-lain commented Dec 7, 2024

Hi @bhavnicksm

By token parameter, do you mean the hf_token?

yess, exactly, the token can either be passed explicitly, or retrieved from the login credentials

As far as I know, Tokenizers rarely change over revisions. Do you see it being used in a specific tokenizer case that changes often?

To be 100% transparent, I haven't seen anything like that, but it could be a nice addition for developers.

Let me know how if you have any feedback about any of these parameters.

@bhavnicksm
Copy link
Collaborator

bhavnicksm commented Dec 11, 2024

By token parameter, do you mean the hf_token?

yess, exactly, the token can either be passed explicitly, or retrieved from the login credentials

Hey @not-lain!

Thanks for the update! Yes, token makes sense for sure~ I'd prefer holding off on revisions for now since we don't see it being needed just yet... to keep the argument space a bit minimal. If it is required in the future, we can add it then!

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants