-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue #28 #29
base: master
Are you sure you want to change the base?
Fixed issue #28 #29
Conversation
Shouldn't it be Plugin Source Reference: https://android.googlesource.com/platform/tools/base/+/gradle_0.11.1/build-system/gradle/src/main/groovy/com/android/build/gradle/internal/api/DefaultAndroidSourceDirectorySet.java |
maybe :) but |
Strange that |
please, correct my patch if I'm wrong. because I'm actually noob in groovy |
You're not necessarily wrong, because you're right that it works. I'm just really confused as to why it works. I'm a total groovy noob as well, which is why I wouldn't be surprised if there is some magic somewhere that is adding that |
Also, might be worth while adding in this patch as well, is the auto-linking to the Android documentation for referenced classes. task androidJavadocs(type: Javadoc) {
/* ... */
options {
linksOffline "http://d.android.com/reference", "${android.sdkDirectory}/docs/reference"
}
exclude '**/R.html', '**/R.*.html'
} |
@cocoahero well, you was right. google-guys answered about the same thing: https://code.google.com/p/android/issues/detail?id=71174#c3 |
This hasn't been fixed in mainline gradle-mvn-push, so referencing the following commit from a PR that looks like it will be merged: shamanland/gradle-mvn-push@cc18d56 chrisbanes/gradle-mvn-push#29 chrisbanes/gradle-mvn-push#28
@ok3141 @cocoahero your commits merged to https://github.com/Vorlonsoft/GradleMavenPush |
I also added property POM_DEVELOPER_EMAIL and disabled failing build in case of javadoc errors appears.