New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not properly handling punycode URLs #466

Closed

chadboyda opened this issue Dec 11, 2015 · 1 comment

chadboyda commented Dec 11, 2015

isURL fails on http://xn------eddceddeftq7bvv7c4ke4c.xn--p1ai/ because of the following check for triple hyphens.

https://github.com/chriso/validator.js/blame/master/validator.js#L403

Punycode Translation:
взять-деньги-в-долг.рф => xn------eddceddeftq7bvv7c4ke4c.xn--p1ai

Domain can be validated here: http://xn--domain.net/
Removing the hyphens would invalidate the punycode.

Collaborator

chriso commented Dec 13, 2015

Thanks for letting me know. I'll disable the triple hyphen check when it's an IDNA.

chriso closed this as completed in

a2bf05d

This was referenced Feb 16, 2016

isFQDN rejecting domains with more than two hypens #498

Closed

Changes to isURL #500

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment