Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for Tunisia National Identity Card #1112

Merged
merged 4 commits into from
Apr 4, 2020

Conversation

CodeIter
Copy link
Contributor

test Successfully passed

yarn clean.win
yarn run v1.17.3
$ yarn clean:node.win && yarn clean:browser.win
$ RMDIR /S /Q lib && ERASE /F /Q index.js
$ ERASE /F /Q validator*.js
Done in 1.76s.

yarn buildtest
yarn run v1.17.3
$ yarn build && yarn lint:fix && yarn test
$ yarn build:browser && yarn build:node
$ node --require @babel/register build-browser && yarn minify
$ uglifyjs validator.js -o validator.min.js  --compress --mangle --comments /Copyright/
$ babel src -d .
Successfully compiled 80 files with Babel.
$ eslint --fix src test
$ yarn lint && yarn build
$ eslint src test
$ yarn build:browser && yarn build:node
$ node --require @babel/register build-browser && yarn minify
$ uglifyjs validator.js -o validator.min.js  --compress --mangle --comments /Copyright/
$ babel src -d .
Successfully compiled 80 files with Babel.
$ nyc mocha --require @babel/register --reporter dot


  ..........................................................................................
  .......................................................................

  161 passing (362ms)


=============================== Coverage summary ===============================
Statements   : 100% ( 1017/1017 )
Branches     : 100% ( 632/632 )
Functions    : 100% ( 96/96 )
Lines        : 100% ( 986/986 )
================================================================================
Done in 64.79s.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! 🎉
Just a comment from me.

package.json Show resolved Hide resolved
@profnandaa
Copy link
Member

@CodeIter -- just the merge conflicts and we are good. Thanks and welcome to contributors! 🎉

@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Feb 17, 2020
@profnandaa
Copy link
Member

ping @CodeIter
/cc. @tux-tn

CodeIter added 4 commits April 2, 2020 14:34
test Successfully passed

Signed-off-by: Mohamed Amin Boubaker <[email protected]>
  clean.win : clean script for windows
  buildtest : one script to build and test
since pretest will be called automatically by npm test

Signed-off-by: Mohamed Amin Boubaker <[email protected]>
Copy link
Contributor Author

@CodeIter CodeIter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflict resolved

@CodeIter CodeIter requested a review from profnandaa April 2, 2020 16:15
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@profnandaa profnandaa merged commit db633ed into validatorjs:master Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mc-to-land Just merge-conflict standing between the PR and landing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants