Add isEthereumAddress #1117
Merged
Add isEthereumAddress #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hizkifw if I get some time, I will review this work. |
Basic validation for Ethereum addresses
hizkifw
force-pushed
the
add-eth-validation
branch
from
51e95ef to
12cb8ee
Compare
ezkemboi
reviewed
Oct 14, 2019
| @@ -0,0 +1,8 @@ | |||
| import assertString from './util/assertString'; | |||
|
|
|||
| const eth = /^(0x)[0-9a-f]{40}$/i; | |||
There was a problem hiding this comment.
I am just asking, don't we have any capitalize/uppercase for Ethereum Address?
There was a problem hiding this comment.
Ethereum addresses can be either all-caps or all-lower, which is why I added the /i flag to mark the regex as case insensitive. Addresses with mixed casing (e.g. 0xdAC17F958D2ee523a2206206994597C13D831ec7) contain checksum information to make sure it's correct, but they require additional dependencies to compute and check.
ezkemboi
approved these changes
Oct 14, 2019
profnandaa
approved these changes
Feb 14, 2020
profnandaa
added
ready-to-land
profnandaa
requested changes
Feb 15, 2020
es/index.js
Outdated
| @@ -23,6 +23,7 @@ import isFullWidth from './lib/isFullWidth'; | |||
| import isHalfWidth from './lib/isHalfWidth'; | |||
| import isVariableWidth from './lib/isVariableWidth'; | |||
| import isMultibyte from './lib/isMultibyte'; | |||
| import isSemVer from './lib/isSemVer'; | |||
There was a problem hiding this comment.
remove the unrelated changes...
hizkifw
force-pushed
the
add-eth-validation
branch
from
07e5825 to
cef7a77
Compare
profnandaa
approved these changes
Feb 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic validation for Ethereum addresses. Checksums are not validated to avoid dependencies.