Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added nepal number #1162

Merged
merged 5 commits into from
Nov 5, 2019
Merged

added nepal number #1162

merged 5 commits into from
Nov 5, 2019

Conversation

rubiin
Copy link
Member

@rubiin rubiin commented Oct 16, 2019

No description provided.

@rubiin
Copy link
Member Author

rubiin commented Oct 16, 2019

@profnandaa @ezkemboi

@ezkemboi
Copy link
Member

@rubiin does this mean that the other PR will be obsolete?

@rubiin
Copy link
Member Author

rubiin commented Oct 16, 2019

@rubiin does this mean that the other PR will be obsolete?

Yes .some files in the other prs modified by the test script was staged , so i thought it would be better to start fresh instead of fixing things @ezkemboi

@ezkemboi
Copy link
Member

Alright, you can close the other PR.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contrib! 🎉

@profnandaa
Copy link
Member

@ezkemboi -- I can use extra pair of eyes.

@ezkemboi
Copy link
Member

I will do that @profnandaa.

@profnandaa
Copy link
Member

Can fix the merge conflict @rubiin

@rubiin
Copy link
Member Author

rubiin commented Oct 21, 2019

In which files

@profnandaa
Copy link
Member

@rubiin -- README.md, as show in the checks above/below.

@rubiin
Copy link
Member Author

rubiin commented Oct 22, 2019

@profnandaa done

README.md Outdated Show resolved Hide resolved
@rubiin rubiin requested a review from profnandaa October 26, 2019 12:33
@rubiin
Copy link
Member Author

rubiin commented Oct 30, 2019

@ezkemboi @profnandaa check this out

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks for the PR! 🎉

@profnandaa profnandaa merged commit e630269 into validatorjs:master Nov 5, 2019
@rubiin
Copy link
Member Author

rubiin commented Nov 5, 2019

Anytime mate, let me know if i can do anything else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants