Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed isMobile (ja-JP) #1166

Merged
merged 3 commits into from
Oct 18, 2019
Merged

Fixed isMobile (ja-JP) #1166

merged 3 commits into from
Oct 18, 2019

Conversation

ayala-io
Copy link
Contributor

@ayala-io ayala-io commented Oct 18, 2019 •
edited
Loading

Modified ja-JP check to do the following:

  • Allow space or dash between the +81 country code and the local area code
  • In the case that +81 is included, allow leading zero in parenthesis of local area code as often done on Japanese business cards i.e. +81 (0)90 1234 5678

Previous test cases still pass. Added additional test cases to test the modifications.

profnandaa
profnandaa approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution 🎉

@profnandaa profnandaa merged commit 659a758 into validatorjs:master Oct 18, 2019
@ayala-io ayala-io deleted the fix-isMobile-JP branch October 18, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayala-io @profnandaa