Updated mobile phone number validator and test #1167

MladenZeljic · 2019-10-19T19:58:29Z

Added verification for bosnian mobile phone numbers

Fixed bs locale

MladenZeljic · 2019-10-19T21:06:49Z

@ezkemboi @profnandaa Hello! I hope that my changes are ok codewise :-)

ezkemboi · 2019-10-20T06:51:19Z

I think those are the files that are required to be changed.
Did you run tests?
Also for faster review, you can send a referral link where we can get information on Bosnian locale mobile phone numbers (Not A must).

MladenZeljic · 2019-10-20T18:13:08Z

@ezkemboi Hey, thanks for reviewing. Yes I did run the tests, they are ending with the most beautiful color (green) x-D. I am from Bosnia and these are the most used, standard mobile phone numbers in our country.

profnandaa

Thanks for your PR! 🎉

profnandaa · 2019-10-21T13:35:57Z

src/lib/isMobilePhone.js

@@ -12,6 +12,7 @@ const phones = {
  'ar-SA': /^(!?(\+?966)|0)?5\d{8}$/,
  'ar-SY': /^(!?(\+?963)|0)?9\d{8}$/,
  'ar-TN': /^(\+?216)?[2459]\d{7}$/,
+  'bs-BA': /^((((\+|0{2})3876)|06)[0-6])((?<=4)\d{7}|(?<!4)\d{6})$/,


Looks like this regex could be simplified? Please check how the rest were written...

I can rewrite and simplify it, but with that, this regex will leave out some forms of mobile phone numbers which are valid in my country. Its your choice :-)

Ok, I see. I'll take this in...

profnandaa

LGTM, thanks for your PR! 🎉

Will just request one extra pair of eyes on this and we land it. /cc. @ezkemboi @tux-tn

tux-tn · 2019-10-23T14:49:16Z

README.md

@@ -122,7 +122,7 @@ Validator                               | Description
 **isMagnetURI(str)**                      | check if the string is a [magnet uri format](https://en.wikipedia.org/wiki/Magnet_URI_scheme).
 **isMD5(str)**                          | check if the string is a MD5 hash.
 **isMimeType(str)**                     | check if the string matches to a valid [MIME type](https://en.wikipedia.org/wiki/Media_type) format
-**isMobilePhone(str [, locale [, options]])**          | check if the string is a mobile phone number,<br/><br/>(locale is either an array of locales (e.g `['sk-SK', 'sr-RS']`) OR one of `['ar-AE', 'ar-BH', 'ar-DZ', 'ar-EG', 'ar-IQ', ar-JO', 'ar-KW', 'ar-SA', 'ar-SY', 'ar-TN', 'be-BY', 'bg-BG', 'bn-BD', 'cs-CZ', 'de-DE', 'de-AT', 'da-DK', 'el-GR', 'en-AU', 'en-CA', 'en-GB', 'en-GG', 'en-GH', 'en-HK', 'en-IE', 'en-IN',  'en-KE', 'en-MT', 'en-MU', 'en-NG', 'en-NZ', 'en-RW', 'en-SG', 'en-UG', 'en-US', 'en-TZ', 'en-ZA', 'en-ZM', 'en-PK', 'es-ES', 'es-MX', 'es-PA', 'es-PY', 'es-UY', 'et-EE', 'fa-IR', 'fi-FI', 'fj-FJ', 'fr-FR', 'fr-GF', 'fr-GP', 'fr-MQ', 'fr-RE', 'he-IL', 'hu-HU', 'id-ID', 'it-IT', 'ja-JP', 'kk-KZ', 'ko-KR', 'lt-LT', 'ms-MY', 'nb-NO', 'nl-BE', 'nl-NL', 'nn-NO', 'pl-PL', 'pt-PT', 'pt-BR', 'ro-RO', 'ru-RU', 'sl-SI', 'sk-SK', 'sr-RS', 'sv-SE', 'th-TH', 'tr-TR', 'uk-UA', 'vi-VN', 'zh-CN', 'zh-HK', 'zh-TW']` OR defaults to 'any'. If 'any' or a falsey value is used, function will check if any of the locales match).<br/><br/>`options` is an optional object that can be supplied with the following keys: `strictMode`, if this is set to `true`, the mobile phone number must be supplied with the country code and therefore must start with `+`. Locale list is `validator.isMobilePhoneLocales`.
+**isMobilePhone(str [, locale [, options]])**          | check if the string is a mobile phone number,<br/><br/>(locale is either an array of locales (e.g `['sk-SK', 'sr-RS']`) OR one of `['ar-AE', 'ar-BH', 'ar-DZ', 'ar-EG', 'ar-IQ', ar-JO', 'ar-KW', 'ar-SA', 'ar-SY', 'ar-TN', 'ba-BS', 'be-BY', 'bg-BG', 'bn-BD', 'cs-CZ', 'de-DE', 'de-AT', 'da-DK', 'el-GR', 'en-AU', 'en-CA', 'en-GB', 'en-GG', 'en-GH', 'en-HK', 'en-IE', 'en-IN',  'en-KE', 'en-MT', 'en-MU', 'en-NG', 'en-NZ', 'en-RW', 'en-SG', 'en-UG', 'en-US', 'en-TZ', 'en-ZA', 'en-ZM', 'en-PK', 'es-ES', 'es-MX', 'es-PA', 'es-PY', 'es-UY', 'et-EE', 'fa-IR', 'fi-FI', 'fj-FJ', 'fr-FR', 'fr-GF', 'fr-GP', 'fr-MQ', 'fr-RE', 'he-IL', 'hu-HU', 'id-ID', 'it-IT', 'ja-JP', 'kk-KZ', 'ko-KR', 'lt-LT', 'ms-MY', 'nb-NO', 'nl-BE', 'nl-NL', 'nn-NO', 'pl-PL', 'pt-PT', 'pt-BR', 'ro-RO', 'ru-RU', 'sl-SI', 'sk-SK', 'sr-RS', 'sv-SE', 'th-TH', 'tr-TR', 'uk-UA', 'vi-VN', 'zh-CN', 'zh-HK', 'zh-TW']` OR defaults to 'any'. If 'any' or a falsey value is used, function will check if any of the locales match).<br/><br/>`options` is an optional object that can be supplied with the following keys: `strictMode`, if this is set to `true`, the mobile phone number must be supplied with the country code and therefore must start with `+`. Locale list is `validator.isMobilePhoneLocales`.


You have a little typo, locale is bs-BA and not ba-BS

Whoops D-:
I'll update it :-D

Updated locale in readme

profnandaa · 2020-03-22T18:56:40Z

@MladenZeljic -- sorry for my delay in re-checking this. Could you just fix the m/c and we should be ready to land this?

MladenZeljic · 2020-06-01T21:05:12Z

Hey @profnandaa, sorry about the delay, I was very busy these past couple of months. I can try to get to this in next few days if thats ok?

MladenZeljic · 2020-06-01T21:30:38Z

Hey @profnandaa I was able to get this done today. If everything is cool you can merge this. Sorry for waiting this long and thank you :-)

profnandaa

LGTM, thanks for the contrib! 🎉

coz of backward compatibility issue #1354

MladenZeljic added 2 commits October 19, 2019 21:55

Updated mobile phone number validator and test

018af0d

Added verification for bosnian mobile phone numbers

Update isMobilePhone.js

9ab98a3

Fixed bs locale

profnandaa reviewed Oct 21, 2019

View reviewed changes

profnandaa approved these changes Oct 22, 2019

View reviewed changes

profnandaa added the needs-more-review label Oct 22, 2019

tux-tn requested changes Oct 23, 2019

View reviewed changes

Update README.md

b160392

Updated locale in readme

profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. 🧹 needs-update For PRs that need to be updated before landing and removed needs-more-review labels Mar 22, 2020

Merge branch 'master' of https://github.com/validatorjs/validator.js

d4a6a06

profnandaa approved these changes Jun 2, 2020

View reviewed changes

profnandaa merged commit c5cab7d into validatorjs:master Jun 2, 2020

profnandaa added a commit that referenced this pull request Jun 11, 2020

hot-fix: revert #1167

99592c2

coz of backward compatibility issue #1354

profnandaa mentioned this pull request Jun 11, 2020

hot-fix: revert #1167 #1355

Merged

3 tasks

chriso pushed a commit that referenced this pull request Jun 11, 2020

fix(isMobilePhone): revert #1167 (#1355)

bdaeced

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated mobile phone number validator and test #1167

Updated mobile phone number validator and test #1167

MladenZeljic commented Oct 19, 2019

MladenZeljic commented Oct 19, 2019

ezkemboi commented Oct 20, 2019 •

edited

Loading

MladenZeljic commented Oct 20, 2019

profnandaa left a comment

profnandaa Oct 21, 2019

MladenZeljic Oct 21, 2019

profnandaa Oct 22, 2019

profnandaa left a comment

tux-tn Oct 23, 2019

MladenZeljic Oct 23, 2019

profnandaa commented Mar 22, 2020

MladenZeljic commented Jun 1, 2020 •

edited

Loading

MladenZeljic commented Jun 1, 2020 •

edited

Loading

profnandaa left a comment

Updated mobile phone number validator and test #1167

Updated mobile phone number validator and test #1167

Conversation

MladenZeljic commented Oct 19, 2019

MladenZeljic commented Oct 19, 2019

ezkemboi commented Oct 20, 2019 • edited Loading

MladenZeljic commented Oct 20, 2019

profnandaa left a comment

Choose a reason for hiding this comment

profnandaa Oct 21, 2019

Choose a reason for hiding this comment

MladenZeljic Oct 21, 2019

Choose a reason for hiding this comment

profnandaa Oct 22, 2019

Choose a reason for hiding this comment

profnandaa left a comment

Choose a reason for hiding this comment

tux-tn Oct 23, 2019

Choose a reason for hiding this comment

MladenZeljic Oct 23, 2019

Choose a reason for hiding this comment

profnandaa commented Mar 22, 2020

MladenZeljic commented Jun 1, 2020 • edited Loading

MladenZeljic commented Jun 1, 2020 • edited Loading

profnandaa left a comment

Choose a reason for hiding this comment

ezkemboi commented Oct 20, 2019 •

edited

Loading

MladenZeljic commented Jun 1, 2020 •

edited

Loading

MladenZeljic commented Jun 1, 2020 •

edited

Loading