-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Algeria Passport (DZ) #1265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @annymosse
You need to add test cases to your newly added country code
hi @tux-tn , i didn't coz there's no need, after all it will just reuse it as any other similar patterns like (US,Ukraine,...) ,however it's easy to do it (I will copy - past similar testers. "sahla barcha barcha 😅") |
@annymosse i know that the same pattern exists in other country codes but it will help to detect if someone else mistakenly edited DZ regex or isPassport validator and also to keep 100% code coverage in the project 😄 |
add missing Algeria Country passport tester
You have a right , i forgot this kind of mistakes . |
@annymosse fix the trailing space issue (check the latest pipeline) and it should be all good |
remove missing trailing spaces.
i thought there's no problem thank you @tux-tn for your mention and remind 👍 . |
remove the rare invalid cases to be fully invalid cases instead of them.
Thank you for your responsiveness! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contrib, and welcome to the project 🎉
@profnandaa you're welcomed 👍 |
Add Algeria (DZ) RegEx passport code.