Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Algeria Passport (DZ) #1265

Merged
merged 4 commits into from
Mar 5, 2020
Merged

feat: Add Algeria Passport (DZ) #1265

merged 4 commits into from
Mar 5, 2020

Conversation

annymosse
Copy link

Add Algeria (DZ) RegEx passport code.

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @annymosse
You need to add test cases to your newly added country code

@annymosse
Copy link
Author

hi @tux-tn , i didn't coz there's no need, after all it will just reuse it as any other similar patterns like (US,Ukraine,...) ,however it's easy to do it (I will copy - past similar testers. "sahla barcha barcha 😅")

@tux-tn
Copy link
Member

tux-tn commented Mar 5, 2020

@annymosse i know that the same pattern exists in other country codes but it will help to detect if someone else mistakenly edited DZ regex or isPassport validator and also to keep 100% code coverage in the project 😄

add missing Algeria Country passport tester
@annymosse
Copy link
Author

@annymosse i know that the same pattern exists in other country codes but it will help to detect if someone else mistakenly edited DZ regex or isPassport validator and also to keep 100% code coverage in the project

You have a right , i forgot this kind of mistakes .

@tux-tn
Copy link
Member

tux-tn commented Mar 5, 2020

@annymosse fix the trailing space issue (check the latest pipeline) and it should be all good

@annymosse
Copy link
Author

i thought there's no problem thank you @tux-tn for your mention and remind 👍 .

remove the rare invalid cases to be fully invalid cases instead of them.
@tux-tn
Copy link
Member

tux-tn commented Mar 5, 2020

Thank you for your responsiveness!
@profnandaa Can you check this PR when you have time?

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contrib, and welcome to the project 🎉

@profnandaa profnandaa merged commit 2eb4049 into validatorjs:master Mar 5, 2020
@annymosse
Copy link
Author

@profnandaa you're welcomed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants