Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(isMobilePhone): add support for de-CH #1314

Merged
merged 4 commits into from
May 27, 2020
Merged

feat(isMobilePhone): add support for de-CH #1314

merged 4 commits into from
May 27, 2020

Conversation

MariuszKogut
Copy link
Contributor

Add support for Swiss mobile numbers.

Source for reg-validation:
image

https://en.wikipedia.org/wiki/Telephone_numbers_in_Switzerland

profnandaa
profnandaa requested changes May 26, 2020
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contrib! 🎉 Just 2 things, my comment below + updating the README to include the new locale.

test/validators.js Outdated Show resolved Hide resolved
@MariuszKogut MariuszKogut requested a review from profnandaa May 27, 2020 06:27
profnandaa
profnandaa approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@profnandaa profnandaa merged commit f2ffa59 into validatorjs:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MariuszKogut @profnandaa