Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hi，isMobilePhone need support 166 section with locale of 'zh-CN' #768

Merged
merged 2 commits into from
Jan 26, 2018
Merged

Hi，isMobilePhone need support 166 section with locale of 'zh-CN' #768

merged 2 commits into from
Jan 26, 2018

Conversation

angus1105
Copy link
Contributor

profnandaa
profnandaa reviewed Dec 22, 2017
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add some tests and any reference that's informing this change?

@angus1105
Copy link
Contributor Author

sorry, here the reference: Section 166 of China Unicom started the number

@lushijie
Copy link

Waiting for accept the pr.

@lushijie lushijie mentioned this pull request Jan 26, 2018
Closed
@chriso chriso merged commit 121e44e into validatorjs:master Jan 26, 2018
@dependabot-preview dependabot-preview bot mentioned this pull request Mar 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@angus1105 @lushijie @profnandaa @chriso