Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decoder/stateless/h265: output buffers computation does not look correct #87

Open
Gnurou opened this issue Jul 11, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@Gnurou
Copy link
Collaborator

Gnurou commented Jul 11, 2024

We currently need to add 16 to the Sps reported max_dpb_size in order for all Fluster tests to pass. RPS_E_qualcomm_5.bit is the only one that requires this.

In order to avoid wasting memory we don't submit the workaround, but here it is:

diff --git a/src/decoder/stateless/h265/vaapi.rs b/src/decoder/stateless/h265/vaapi.rs
index 43e5a1914..fb337d11c 100644
--- a/src/decoder/stateless/h265/vaapi.rs
+++ b/src/decoder/stateless/h265/vaapi.rs
@@ -124,7 +124,9 @@ impl VaStreamInfo for &Sps {
     }

     fn min_num_surfaces(&self) -> usize {
-        self.max_dpb_size() + 4
+        // TODO: + 16 is needed to make Fluster's RPS_E_qualcomm_5.bit test pass. Other tests are
+        // happy with + 4. We should investigate why this is the case.
+        self.max_dpb_size() + 16
     }

     fn coded_size(&self) -> (u32, u32) {
@Gnurou Gnurou added the bug Something isn't working label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant