-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take usage of URI fragments #411
Conversation
- Avoid requests to join the just joined room
I created a PR to add cinny to the list of clients in https://matrix.to but it would be better UX if you could directly go the room instead of copy-pasting it into the client. BTW: how should we handly copyright attribution of the cinny logo? |
as this pr's dependency was merged, is there anything it's currently waiting on ? |
src/util/uriFragments.js
Outdated
const pieces = window.location.hash.split('/'); | ||
if (!eventId) pieces.length = 3; | ||
else pieces[3] = eventId; | ||
if (!selectRoom) pieces.length = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo. Should be:
if (!selectedRoom) pieces.length = 2;
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
Preview: https://411--pr-cinny.netlify.app |
Thank you a lot for the continued efforts on this. I just tested the netlify-hosted version of this PR, and it's shaping up really nicely!
|
https://github.com/cinnyapp/cinny/pull/411/files#diff-cc58d91e2c920c0129c91191387a190b861bb84e12775c6f729ddcda65ce1f1fR40-R44 seems to be the problem. No code after is executed With it removed, "back" and "forward" work too |
taken from cinnyapp#411. Removed space selector, as it prevents code from being executed after it
taken from cinnyapp#411. Removed space selector, as it prevents code from being executed after it
taken from cinnyapp#411. Removed space selector, as it prevents code from being executed after it
taken from cinnyapp#411. Removed space selector, as it prevents code from being executed after it
Closing in favour of #1633 adding the URL navigation. |
Description
It would be handy if we could launch Cinny opening a room automatically.
This would also enable the matrix.to project to add support for Cinny if they would like to do so.
To preserve privacy and room ids etc. to be leaked to the hosting service unnecessarily this leverages URI fragments over URI queries or paths.
Paths and queries are being sent to the server, which is not required in this scenario, while fragments are not.
Element handles this "issue" similarly.
Schema
dev.cinny.in/
Fixes #170
Depends on #401
Type of change
Checklist:
Preview: https://627cc9bb10a88f43bce051f0--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️