Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take usage of URI fragments #411

Closed
wants to merge 8 commits into from
Closed

Conversation

C0ffeeCode
Copy link
Contributor

@C0ffeeCode C0ffeeCode commented Mar 22, 2022

Description

It would be handy if we could launch Cinny opening a room automatically.
This would also enable the matrix.to project to add support for Cinny if they would like to do so.

To preserve privacy and room ids etc. to be leaked to the hosting service unnecessarily this leverages URI fragments over URI queries or paths.
Paths and queries are being sent to the server, which is not required in this scenario, while fragments are not.

Element handles this "issue" similarly.

Schema

dev.cinny.in/

  • #/room/[roomid]
  • #/room/[roomid]/[eventid]
  • #/[spaceid]
  • #/[spaceid]/[roomid]
  • #/join/[roomid]

Fixes #170
Depends on #401

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Preview: https://627cc9bb10a88f43bce051f0--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@C0ffeeCode C0ffeeCode marked this pull request as ready for review May 11, 2022 21:49
@Airyzz Airyzz mentioned this pull request Sep 9, 2022
9 tasks
@3nt3
Copy link

3nt3 commented Oct 12, 2022

I created a PR to add cinny to the list of clients in https://matrix.to but it would be better UX if you could directly go the room instead of copy-pasting it into the client.

BTW: how should we handly copyright attribution of the cinny logo?

@theotheroracle
Copy link

as this pr's dependency was merged, is there anything it's currently waiting on ?

@ajbura ajbura self-requested a review April 18, 2023 06:53
const pieces = window.location.hash.split('/');
if (!eventId) pieces.length = 3;
else pieces[3] = eventId;
if (!selectRoom) pieces.length = 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo. Should be:
if (!selectedRoom) pieces.length = 2;

@github-actions
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@github-actions
Copy link

github-actions bot commented Aug 30, 2023

Preview: https://411--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@fnwbr
Copy link

fnwbr commented Nov 28, 2023

Thank you a lot for the continued efforts on this.

I just tested the netlify-hosted version of this PR, and it's shaping up really nicely!
Some things that I noticed that don't work:

  • Using "back" and "forward" history buttons in the browser don't do anything
  • Opening a new window / new session of Cinny and navigating to a room right away, e.g. by clicking on a link such as https://411--pr-cinny.netlify.app/#/room/#cinny:matrix.org will show you the default welcome screen instead of the room you intended to navigate to

@aceArt-GmbH
Copy link
Contributor

aceArt-GmbH commented Dec 11, 2023

https://github.com/cinnyapp/cinny/pull/411/files#diff-cc58d91e2c920c0129c91191387a190b861bb84e12775c6f729ddcda65ce1f1fR40-R44 seems to be the problem. No code after is executed

With it removed, "back" and "forward" work too

cc #70 #108

aceArt-GmbH added a commit to aceArt-GmbH/cinny that referenced this pull request Dec 22, 2023
taken from cinnyapp#411.
Removed space selector, as it prevents code from being executed after it
aceArt-GmbH added a commit to aceArt-GmbH/cinny that referenced this pull request Jan 11, 2024
taken from cinnyapp#411.
Removed space selector, as it prevents code from being executed after it
aceArt-GmbH added a commit to aceArt-GmbH/cinny that referenced this pull request Jan 17, 2024
taken from cinnyapp#411.
Removed space selector, as it prevents code from being executed after it
aceArt-GmbH added a commit to aceArt-GmbH/cinny that referenced this pull request Jan 22, 2024
taken from cinnyapp#411.
Removed space selector, as it prevents code from being executed after it
@kfiven
Copy link
Collaborator

kfiven commented May 22, 2024

Closing in favour of #1633 adding the URL navigation.

@kfiven kfiven closed this May 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

link to open cinny to a certain room
7 participants