Replies: 4 comments 10 replies
-
SocketRefs is needed to keep the ref alive in CFFI without this the ref count goes to 0 and GC cleans the socket data, with HPy this will be solved, we can also move it to the App instead of global just need to check if is faster or not, because each process can have only 1 App by design so is not really an problem. @AmirHmZz Please let's use this discussion to talk about an major refactor also, we will create another branch to do it. We will test all after the refactor and also add unit tests. I need to finish somethings before the refactor starts, but please send all the advice possible about Python. ❤️ Also we can use the https://discord.socketify.dev/ i will create an channel for this. |
Beta Was this translation helpful? Give feedback.
-
@cirospaciari Do you have any uncommitted changes in |
Beta Was this translation helpful? Give feedback.
-
Most of this is already done, and the entire socketify.py, uv.py and native.py files will be rewritten in C++ using HPy soon asgi.py and wsgi.py will be rewritten in another step This will be locked because of the next steps in the current development stage. |
Beta Was this translation helpful? Give feedback.
-
As the first comment I want to make a checklist :
Enums
andOption
classes to other python filesSocketRefs
insocketify.py
) which make access to variables slower a lotdataclass
forOption
classes to reduce boilerplate code ( Merged in this commit )Beta Was this translation helpful? Give feedback.
All reactions