-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove policy MS.SHAREPOINT4.2v1 due to Microsoft update to custom scripting settings #1410
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am good with the changes in this PR. Make sure that #1400 gets into the same release otherwise we would have a ScubaGear report that does not line up with the baseline. Also, check the Sharepoint admin portal and see if the setting for 4.2 has been removed from the user interface and drop a note in the issue connected to this PR for awareness.
@ahuynhMITRE Recommend updating the PR title to reference the policy by ID rather than name and change to use imperative voice (i.e. Removal of -> Remove). |
d6b1427
to
cbadbfc
Compare
Co-authored-by: mitchelbaker-cisa <[email protected]>
🗣 Description
Microsoft is making updates to the custom scripting configuration options for Sharepoint and OneDrive. The purpose of this PR is to remove the SCB references to these settings and add the policy, date of removal, and rationale to the removedpolicies.md.
This would be useful because as Microsoft rolls out this update, users of ScubaGear will experience errors as a result of the missing setting. This allows the ScubaGear and the SCBs to be update to date with this setting deprecation.
💭 Motivation and context
This would be useful because as Microsoft rolls out this update, users of ScubaGear will experience errors as a result of the missing setting. This allows the ScubaGear and the SCBs to be update to date with this setting deprecation.
Closes #1399
🧪 Testing
N/A currently only an SCB update, code change will be in a follow-up issue and PR.
✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
✅ Post-merge checklist