Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove policy MS.SHAREPOINT4.2v1 due to Microsoft update to custom scripting settings #1410

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ahuynhMITRE
Copy link
Collaborator

@ahuynhMITRE ahuynhMITRE commented Nov 8, 2024

🗣 Description

Microsoft is making updates to the custom scripting configuration options for Sharepoint and OneDrive. The purpose of this PR is to remove the SCB references to these settings and add the policy, date of removal, and rationale to the removedpolicies.md.

This would be useful because as Microsoft rolls out this update, users of ScubaGear will experience errors as a result of the missing setting. This allows the ScubaGear and the SCBs to be update to date with this setting deprecation.

💭 Motivation and context

This would be useful because as Microsoft rolls out this update, users of ScubaGear will experience errors as a result of the missing setting. This allows the ScubaGear and the SCBs to be update to date with this setting deprecation.

Closes #1399

🧪 Testing

N/A currently only an SCB update, code change will be in a follow-up issue and PR.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@ahuynhMITRE ahuynhMITRE added the baseline-document Issues relating to the text in the baseline documents themselves label Nov 8, 2024
@ahuynhMITRE ahuynhMITRE added this to the Kraken milestone Nov 8, 2024
@ahuynhMITRE ahuynhMITRE self-assigned this Nov 8, 2024
Copy link
Collaborator

@tkol2022 tkol2022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good with the changes in this PR. Make sure that #1400 gets into the same release otherwise we would have a ScubaGear report that does not line up with the baseline. Also, check the Sharepoint admin portal and see if the setting for 4.2 has been removed from the user interface and drop a note in the issue connected to this PR for awareness.

@schrolla
Copy link
Collaborator

@ahuynhMITRE Recommend updating the PR title to reference the policy by ID rather than name and change to use imperative voice (i.e. Removal of -> Remove).

@ahuynhMITRE ahuynhMITRE changed the title Removal of Remove Custom Script setting policy references in the SharePoint SCB due to Microsofts update to the setting SCB Update: Remove policy MS.SHAREPOINT4.2v1 due to Microsoft update to custom scripting settings Nov 11, 2024
@ahuynhMITRE ahuynhMITRE changed the title SCB Update: Remove policy MS.SHAREPOINT4.2v1 due to Microsoft update to custom scripting settings Remove policy MS.SHAREPOINT4.2v1 due to Microsoft update to custom scripting settings Nov 12, 2024
@mitchelbaker-cisa mitchelbaker-cisa force-pushed the 1399-scb-update-removal-of-decommissioning-custom-script-sharepoint-online-settings-from-the-scbs branch from d6b1427 to cbadbfc Compare November 15, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
baseline-document Issues relating to the text in the baseline documents themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SCB Update: Removal of decommissioning Custom Script SharePoint Online settings from the SCBs
4 participants