Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify License Requirements in assumptions.md #1439

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

adhilto
Copy link
Collaborator

@adhilto adhilto commented Nov 21, 2024

🗣 Description

Clarify License Requirements in assumptions.md. Note the option of using a config file to document use of third-party tools.

💭 Motivation and context

More clarity was needed.

🧪 Testing

N/A

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

  • Demonstrate changes to the team for questions and comments.
    (Note: Only required for issues of size Medium or larger)

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@adhilto adhilto added the documentation This issue or pull request improves or adds to documentation label Nov 21, 2024
@adhilto adhilto added this to the Kraken milestone Nov 21, 2024
@adhilto adhilto self-assigned this Nov 21, 2024
docs/misc/assumptions.md Outdated Show resolved Hide resolved
docs/misc/assumptions.md Outdated Show resolved Hide resolved

Some of the policy checks in the baselines rely on the following licenses, which are included by default in M365 E5 and G5:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MS.DEFENDER.6.3v1 (audit log duration/OMB 21-31 memo) lists the Microsoft Purview Audit (Premium) license requirement. Is it worth listing here if agencies are already mandated to have advanced logging capability?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They shouldn't be mandated to have Purview Audit (Premium) in practice anymore because of the changes in the log types included in Purview (standard), which is observed in the note for MS.DEFENDER.6.2v1

As for retention, they may choose to retain it in Microsoft using purview or use a third party solution (Splunk, etc) in their SOC. Both would meet the policy, as is explained in the note for that policy.

Copy link
Collaborator Author

@adhilto adhilto Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't count Purview Audit (Premium), "almost all cases...can be met using a third-party service" becomes "all cases." That was the one exception. I'll take out the "almost."

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about MS.AAD.2.{1-3}v1 required AAD P2 as well? Agree there are not many.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I wasn't tracking that one.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For tracking purposes in MS.AAD.4.1v1 -- we say an Azure subscription may be required for forwarding logs to a SIEM, although which SIEM an agency uses falls under the 3rd-party service category.

adhilto and others added 4 commits November 22, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This issue or pull request improves or adds to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants