Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoneType Affected Systems Trigger an Error on the Report Screen #126

Open
karendm opened this issue Jan 17, 2025 · 0 comments
Open

NoneType Affected Systems Trigger an Error on the Report Screen #126

karendm opened this issue Jan 17, 2025 · 0 comments
Assignees
Labels
bug This issue or pull request addresses broken functionality

Comments

@karendm
Copy link
Collaborator

karendm commented Jan 17, 2025

Current Behavior

Currently, an affected system that is added to a finding but not given a name is added as a NoneType object. This causes an error on the Report screen and while trying to access the corresponding Affected System object within the Admin portal.

Expected Behavior

RE should not create an AffectedSystem object unless it is given a name. Error handling on the Report screen and throughout the app should include resilience to NoneType objects so that the app continues to function normally.

Steps to Reproduce

  1. Add a Finding
  2. On the Create Finding screen, fill in required fields
  3. On the Create Finding screen, add an Affected System but do not modify any of the Affected System fields (leave it blank)
  4. Save the finding
  5. Navigate to the Report screen and/or to the null AffectedSystem object (should be labelled with a - symbol)
  6. View the error in the GUI or logs
@karendm karendm self-assigned this Jan 17, 2025
@karendm karendm added the bug This issue or pull request addresses broken functionality label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

No branches or pull requests

1 participant