Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When npm fails or is not installed, ptp.py does not report an error, and indicates that the operation was successful. #9

Open
S4lt5 opened this issue Oct 28, 2022 · 0 comments

Comments

@S4lt5
Copy link

S4lt5 commented Oct 28, 2022

The pyp.py operation at https://github.com/cisagov/rva-reporting-engine/blob/f456d4c47dfeb100b5e38cd91f6f36c8f2cd5165/ptp.py#L317

failed on my machine as there is no host-level npm command, but said that everything worked, and blissfully continued on.

which  npm
npm not found./ptp.py dev -r RVA
PT Portal
Loading PT Portal with docker-compose for developers
composing environment variable file for docker-compose
Installing SDS and running postcss for tailwind.
/bin/sh: npm: command not found
/bin/sh: npm: command not found
Successfully installed SDS and tailwind.

The install process should check to see if the npm commands were successful before moving on.

This is missing from the README entirely and should state in prerequisites that it needs to be installed since it is not obvious that this project that appears to be primarily python-based container project needs host-level nodejs installed, and that we'd need the right things in our build image / CI to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant