Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to visual indicator for sorted columns in tables #3396

Open
3 tasks
gabydisarli opened this issue Jan 23, 2025 · 1 comment
Open
3 tasks

Changes to visual indicator for sorted columns in tables #3396

gabydisarli opened this issue Jan 23, 2025 · 1 comment
Labels
dev issue is for the dev team

Comments

@gabydisarli
Copy link
Contributor

gabydisarli commented Jan 23, 2025

Issue description

Our visual indicator for sorted columns in our tables doesn't quite match other branding across the registrar and is visually very heavy. It is required to have a visual indicator on a sorted column. These changes introduce a new style for that indicator.

Acceptance criteria

  • (1) Update visual indicator on table header to match Figma design and annotation
  • Change color fill that applies to the column temporarily on clicking sort to #F5F8FA instead of #7AB9D5
  • make the above changes to every sorted table (or and non org model)

Additional context

No response

Links to other issues

🔄 Members review #3280

@gabydisarli gabydisarli added the dev issue is for the dev team label Jan 23, 2025
@abroddrick abroddrick moved this from 👶 New to ⚙ Dev Parking Lot in .gov Product Board Jan 24, 2025
@abroddrick
Copy link
Contributor

@gabydisarli Isn't the USWDS standard to fill the column in a different color? The figma looks like the color gets fully removed, not just changing the indicator on the header.

@gabydisarli gabydisarli changed the title Changes to visual indicator for sorted columns in tables Changes to visual indicator for sorted columns + padding changes in tables Jan 29, 2025
@gabydisarli gabydisarli changed the title Changes to visual indicator for sorted columns + padding changes in tables Changes to visual indicator for sorted columns in tables Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev issue is for the dev team
Projects
Status: ⚙ Dev Parking Lot
Development

No branches or pull requests

2 participants