Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine DataGridTextField components #20213

Closed
mddilley opened this issue Dec 9, 2024 · 0 comments · Fixed by cityofaustin/atd-moped#1516
Closed

Combine DataGridTextField components #20213

mddilley opened this issue Dec 9, 2024 · 0 comments · Fixed by cityofaustin/atd-moped#1516
Assignees
Labels
Product: Moped A comprehensive mobility project tracking platform for Austin, Texas Service: Dev Infrastructure and engineering Type: Snackoo 🍫 Small straightforward issues or fun bugs Type: Tech Debt Code or processes that require more work to optimize sustainability, performance, etc. Workgroup: DTS Data and Technology Services

Comments

@mddilley
Copy link

mddilley commented Dec 9, 2024

While migrating tables to DataGridPro, two reusable component were created for TextField edit inputs. One supports the multiline textfield option, and the other does not. We should keep the one that does and update other inputs that would benefit from having multiline input so users can see their entire text while entering it.

In Scope

  • Keep moped-editor/src/components/DataGridPro/DataGridTextField.js (the one that is extended with the multiline option)
  • Remove moped-editor/src/views/projects/projectView/DataGridTextField.js and update imports
  • Use theme.spacing(1) to prevent the highlighted input underline from colliding with the edge of the highlighted cell outline (see below)
  • Add multiline option to:
    • Project files name and description columns
    • Project milestones description column
    • Project funding description column

Prevent this:
Screenshot 2024-12-12 at 3.43.29 PM.png

@mddilley mddilley added Workgroup: DTS Data and Technology Services Service: Dev Infrastructure and engineering Product: Moped A comprehensive mobility project tracking platform for Austin, Texas Type: Tech Debt Code or processes that require more work to optimize sustainability, performance, etc. Type: Snackoo 🍫 Small straightforward issues or fun bugs labels Dec 9, 2024
@mddilley mddilley self-assigned this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product: Moped A comprehensive mobility project tracking platform for Austin, Texas Service: Dev Infrastructure and engineering Type: Snackoo 🍫 Small straightforward issues or fun bugs Type: Tech Debt Code or processes that require more work to optimize sustainability, performance, etc. Workgroup: DTS Data and Technology Services
Projects
None yet
1 participant