Skip to content
This repository has been archived by the owner on Aug 29, 2020. It is now read-only.

Crash shortly after starting #99

Closed
ghost opened this issue Jan 26, 2019 · 4 comments
Closed

Crash shortly after starting #99

ghost opened this issue Jan 26, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jan 26, 2019

Summary

Freshly baked 2.0.0; gotop crashes shortly after running for a few minutes. Per time, 2 minutes, 40 seconds after starting.

Required information:

  • gotop command: gotop -b -s -c monokai -p -a
  • gotop version (gotop -v): 2.0.0
  • The output of uname -a: Linux sting 4.20.0-arch1-1-ARCH Increase height of sparkline to match widget height #1 SMP PREEMPT Mon Dec 24 03:00:40 UTC 2018 x86_64 GNU/Linux
  • Terminal shell (e.g. zsh or bash): zsh 5.6.2 (x86_64-pc-linux-gnu)
  • Terminal emulator (e.g. iTerm or gnome terminal): termite v14
  • Any relevenat hardware info: Dell XPS13 9343
  • tmux version if using tmux: tmux 2.8

gotop.errors.log (from ~/.local/state/gotop).

@ghost
Copy link
Author

ghost commented Jan 26, 2019

Updates

  1. No options: no crash after 30m
  2. -b: no crash after 10m

@cjbassi
Copy link
Owner

cjbassi commented Jan 26, 2019

So I think this is the same concurrent map write issue as #96, which turned out to be a different issue than I fixed before. This one is particular to the CPU widget, which potentially spawns 2 goroutines when updating, which each write to the same map. Should be fixed on master now. Thanks again, I should've checked the logs more carefully.

@cjbassi cjbassi added the bug Something isn't working label Jan 26, 2019
@ghost
Copy link
Author

ghost commented Jan 31, 2019

Think I noted this on another ticket, but I'll be able to check this after Feb 8. Thanks for being patient on my confirmation!

@ghost
Copy link
Author

ghost commented Feb 10, 2019

I'm going to close this as confirmed fixed; I updated gotop on the VMs and they've all been running for over a half hour, so any other stability issues probably have some other root cause.

Thanks again for the fix!

@ghost ghost closed this as completed Feb 10, 2019
@ghost ghost mentioned this issue Feb 10, 2019
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant