Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not initialize Emoji plugins if its database is not available #17772

Open
pomek opened this issue Jan 20, 2025 · 0 comments
Open

Do not initialize Emoji plugins if its database is not available #17772

pomek opened this issue Jan 20, 2025 · 0 comments
Assignees
Labels
package:emoji squad:platform Issue to be handled by the Platform team. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@pomek
Copy link
Member

pomek commented Jan 20, 2025

Provide a description of the task

Shortly, when the EmojiDatabase could not fetch the resource from a server, Emoji* plugins should not be initialized because the editor has nothing to show.

Right now, it ends with an ugly error when opening a picker.

emojigridview.ts:216 Uncaught TypeError: Cannot read properties of undefined (reading 'map')
    at EmojiGridView._updateGrid (emojigridview.ts:216:1)
    at EmojiGridView.filter (emojigridview.ts:168:1)
    at EmojiSearchView.search (emojisearchview.ts:68:1)
    at EmojiPicker.showUI (emojipicker.ts:143:1)
    at ButtonView.<anonymous> (emojipicker.ts:168:1)
    at ButtonView.fire (emittermixin.ts:240:1)

EmojiMention does not display anything from the database but suggests using a picker that will not show anything more.

Image

Definition of Ready

Technical details

@pomek pomek added package:emoji squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos". labels Jan 20, 2025
@psmyrek psmyrek self-assigned this Jan 20, 2025
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:emoji squad:platform Issue to be handled by the Platform team. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

3 participants