Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve manual test server output #9220

Closed
pomek opened this issue Mar 11, 2021 · 1 comment · Fixed by ckeditor/ckeditor5-dev#694, nextcloud/mail#4753, nextcloud/mail#4757 or xhj/ckeditor5-build-rails#19
Closed

Improve manual test server output #9220

pomek opened this issue Mar 11, 2021 · 1 comment · Fixed by ckeditor/ckeditor5-dev#694, nextcloud/mail#4753, nextcloud/mail#4757 or xhj/ckeditor5-build-rails#19
Assignees
@pomek
Labels
package:dev squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 41 (v27...

Comments

@pomek
Copy link
Member

pomek commented Mar 11, 2021

Provide a description of the task

Processing '/home/travis/build/ckeditor/ckeditor5/tests/manual/all-features-dll'...
Finished writing '/home/travis/build/ckeditor/ckeditor5/build/.manual-tests/ckeditor5/tests/manual/all-features-dll.html'
Processing '/home/travis/build/ckeditor/ckeditor5/tests/manual/all-features'...
Finished writing '/home/travis/build/ckeditor/ckeditor5/build/.manual-tests/ckeditor5/tests/manual/all-features.html'
Processing '/home/travis/build/ckeditor/ckeditor5/tests/manual/article'...
Finished writing '/home/travis/build/ckeditor/ckeditor5/build/.manual-tests/ckeditor5/tests/manual/article.html'
Processing '/home/travis/build/ckeditor/ckeditor5/tests/manual/mathtype'...
Finished writing '/home/travis/build/ckeditor/ckeditor5/build/.manual-tests/ckeditor5/tests/manual/mathtype.html'
...

Do we need "Finished writing..." messages at all?

If the list of manual tests to check is known, we could display all items in two/three columns. Just to show which tests will be parsed. It would be enough. If webpack can't compile anything, it will end with an error.
@pomek pomek added type:task This issue reports a chore (non-production change) and other types of "todos". package:dev labels Mar 11, 2021
@pomek pomek added this to the nice-to-have milestone Mar 11, 2021
@pomek pomek added the squad:platform Issue to be handled by the Platform team. label Mar 11, 2021
@pomek
Copy link
Member Author

pomek commented Mar 12, 2021

Since the "Processing" and "Finished writing" messages are used by a watcher, it makes sense to keep it as we have it now.

I'd introduce --silent flag that allows hiding those logs. It will be useful on CI.

@pomek pomek self-assigned this Mar 12, 2021
@pomek pomek modified the milestones: nice-to-have, iteration 41 Mar 12, 2021
@pomek pomek mentioned this issue Mar 12, 2021
Merged
pomek added a commit to ckeditor/ckeditor5-dev that referenced this issue Mar 12, 2021
@pomek
Merge pull request #694 from ckeditor/i/9220
b6dc12e 
Other (tests): Added the `--silent` flag to the manual test server that allows hiding names of the processed files. Closes ckeditor/ckeditor5#9220.
This was referenced Mar 13, 2021
Merged
Merged
Closed
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomek pomek

Labels
package:dev squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 41 (v27.0.0)
1 participant
@pomek