Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release checklist for clangd 19 #2127

Closed
8 tasks done
HighCommander4 opened this issue Aug 25, 2024 · 15 comments
Closed
8 tasks done

Release checklist for clangd 19 #2127

HighCommander4 opened this issue Aug 25, 2024 · 15 comments

Comments

@HighCommander4
Copy link

HighCommander4 commented Aug 25, 2024

Using the Release checklist from the wiki as a template:

Once the release branch is created

Once the LLVM release is out

  • Prepare the clangd release on the Github releases page
  • Mark the release as a stable release by unchecking the "pre-release" checkbox.
  • Mark the release as "latest" after a couple weeks if there are no issues.
@nicovank
Copy link

Should TidyFastChecks.inc be updated?

@HighCommander4
Copy link
Author

Should TidyFastChecks.inc be updated?

I will leave this to @sam-mccall / @kadircet to do at a cadence of their choosing.

@HighCommander4
Copy link
Author

HighCommander4 commented Aug 28, 2024

  • Document any notable new features on the clangd website

The only notable new feature that comes to mind is the initial support for C++20 Modules.

@ChuanqiXu9, do you think we should add something to https://clangd.llvm.org/features about it? Or should we wait until the feature is at a more advanced stage?

@ChuanqiXu9
Copy link

  • Document any notable new features on the clangd website

The only notable new feature that comes to mind is the initial support for C++20 Modules.

@ChuanqiXu9, do you think we should add something to https://clangd.llvm.org/features about it? Or should we wait until the feature is at a more advanced stage?

I think we should add it. It will pretty helpful for us to improve this by receiving more issue reports.

@HighCommander4
Copy link
Author

The only notable new feature that comes to mind is the initial support for C++20 Modules.
@ChuanqiXu9, do you think we should add something to https://clangd.llvm.org/features about it? Or should we wait until the feature is at a more advanced stage?

I think we should add it. It will pretty helpful for us to improve this by receiving more issue reports.

Makes sense. Would you like to send a PR? The page source is at https://github.com/llvm/clangd-www/blob/main/features.md.

@ChuanqiXu9
Copy link

The only notable new feature that comes to mind is the initial support for C++20 Modules.
@ChuanqiXu9, do you think we should add something to https://clangd.llvm.org/features about it? Or should we wait until the feature is at a more advanced stage?

I think we should add it. It will pretty helpful for us to improve this by receiving more issue reports.

Makes sense. Would you like to send a PR? The page source is at https://github.com/llvm/clangd-www/blob/main/features.md.

I sent it here: llvm/clangd-www#107

@kadircet
Copy link
Member

Should TidyFastChecks.inc be updated?

I will leave this to @sam-mccall / @kadircet to do at a cadence of their choosing.

thanks for the ping! llvm/llvm-project#106354 for analysis at 19.x, we should also get that cherry-picked to release branch

@HighCommander4
Copy link
Author

I've prepared a 19.1.0 release at https://github.com/clangd/clangd/releases/tag/19.1.0. Marked as pre-release for now, testing is welcome.

@HighCommander4
Copy link
Author

I've now unchecked the pre-release checkbox.

@HighCommander4
Copy link
Author

Note that a crash regression affecting 19.1.0 has been found and fixed on trunk in llvm/llvm-project#109367. I've proposed backporting the fix to the 19.x branch in llvm/llvm-project#111317.

I would like to wait for that fix to appear in a release before marking a 19.x release as "latest".

@amitrahman1026
Copy link

amitrahman1026 commented Oct 11, 2024

Note that a crash regression affecting 19.1.0 has been found and fixed on trunk in llvm/llvm-project#109367. I've proposed backporting the fix to the 19.x branch in llvm/llvm-project#111317.

I would like to wait for that fix to appear in a release before marking a 19.x release as "latest".

I've also encountered the aforementioned bug, where I talked about it here (with backtrace logs) but on Homebrew clangd version 19.1.1. I'm a little confused about this 19.x release terminology as I'm new to looking at llvm's release structure, but does that mean I should be looking out for the next release version?

@HighCommander4
Copy link
Author

I've also encountered the aforementioned bug, where I talked about it here (with backtrace logs) but on Homebrew clangd version 19.1.1. I'm a little confused about this 19.x release terminology as I'm new to looking at llvm's release structure, but does that mean I should be looking out for the next release version?

Yes, 19.1.1 is affected as well.

The backport of this fix to the 19.x branch was just merged within the past day (llvm/llvm-project#111318), so it will appear in the next dot release. According to this thread, that should be 19.1.2 around Oct 15.

Until then, I suggest using clangd 18. It can be obtained from https://github.com/clangd/clangd/releases/tag/18.1.3.

@HighCommander4
Copy link
Author

A 19.1.2 release is now up at https://github.com/clangd/clangd/releases/tag/19.1.2.

@HighCommander4
Copy link
Author

HighCommander4 commented Dec 6, 2024

A 19.1.2 release is now up at https://github.com/clangd/clangd/releases/tag/19.1.2.

I just realized this was still marked as "pre-release"; unchecked that now.

Are we ready to mark this as "latest"?

@HighCommander4
Copy link
Author

Are we ready to mark this as "latest"?

Forgot to circle back to this and tick the "latest" checkbox. Done now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants