From a24c86b865b73cbf4cd2422028a34d32b30cf6b7 Mon Sep 17 00:00:00 2001 From: emily-shen <69125074+emily-shen@users.noreply.github.com> Date: Thu, 10 Oct 2024 15:14:02 +0100 Subject: [PATCH] fix: `pages project delete` should error if project name not specified (#6914) * fix pages project delete demandOption * test --- .../wrangler/src/__tests__/pages/project-delete.test.ts | 8 ++++++++ packages/wrangler/src/pages/projects.tsx | 4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/packages/wrangler/src/__tests__/pages/project-delete.test.ts b/packages/wrangler/src/__tests__/pages/project-delete.test.ts index 0d6ce52f8133..6996e522402e 100644 --- a/packages/wrangler/src/__tests__/pages/project-delete.test.ts +++ b/packages/wrangler/src/__tests__/pages/project-delete.test.ts @@ -63,6 +63,14 @@ describe("pages project delete", () => { `); }); + it("should error if no project name is specified", async () => { + await expect( + runWrangler("pages project delete") + ).rejects.toThrowErrorMatchingInlineSnapshot( + `[Error: Missing required argument: project-name]` + ); + }); + it("should not delete a project if confirmation refused", async () => { mockConfirm({ text: `Are you sure you want to delete "some-project-name-2"? This action cannot be undone.`, diff --git a/packages/wrangler/src/pages/projects.tsx b/packages/wrangler/src/pages/projects.tsx index 97ee6093bd07..761099a23671 100644 --- a/packages/wrangler/src/pages/projects.tsx +++ b/packages/wrangler/src/pages/projects.tsx @@ -188,7 +188,6 @@ export function DeleteOptions(yargs: CommonYargsArgv) { return yargs .positional("project-name", { type: "string", - demandOption: true, description: "The name of your Pages project", }) .options({ @@ -197,7 +196,8 @@ export function DeleteOptions(yargs: CommonYargsArgv) { type: "boolean", description: 'Answer "yes" to confirm project deletion', }, - }); + }) + .demandOption("project-name"); } export async function DeleteHandler(