Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pages-shared): add custom response header when we hit asset preservation cache #7297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(pages-shared): add custom response header when we hit asset preservation cache #7297

wants to merge 1 commit into from

Conversation

M-Krilano
Copy link

@M-Krilano M-Krilano commented Nov 20, 2024 •
edited by WalshyDev
Loading

Adds the x-cf-pgs-apc response header for the pages asset-server handler if the ASSET_PRESERVATION_CACHE_V2 was hit. This allows for easier troubleshooting for cache invalidation issues.

Fixes #7295 .

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no e2e coverage
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because:

@M-Krilano M-Krilano requested review from a team as code owners November 20, 2024 05:48
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2024

⚠️ No Changeset found

Latest commit: bd39571

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11927536952/npm-package-wrangler-7297

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7297/npm-package-wrangler-7297

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11927536952/npm-package-wrangler-7297 dev path/to/script.js
Additional artifacts: 
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11927536952/npm-package-create-cloudflare-7297 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11927536952/npm-package-cloudflare-kv-asset-handler-7297
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11927536952/npm-package-miniflare-7297
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11927536952/npm-package-cloudflare-pages-shared-7297
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11927536952/npm-package-cloudflare-vitest-pool-workers-7297
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11927536952/npm-package-cloudflare-workers-editor-shared-7297
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11927536952/npm-package-cloudflare-workers-shared-7297
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11927536952/npm-package-cloudflare-workflows-shared-7297

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.0
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
workers-sdk
Status: Untriaged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature Request: add custom response header when asset preservation cache is hit
1 participant
@M-Krilano