Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apiserver): Optionally restrict public API to a single client #2954

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

silvestre
Copy link
Member

Issue

As a platform operator you might want to restrict access to the public
API.

Fix

The property autoscaler.apiserver.autoscaler_api_client_id, if set,
restricts the public API endpoint, to only allow requests providing an
oauth token from this client id to access the public API. The token
needs to be provided in the request header X-Autoscaler-Token.

@silvestre silvestre added the allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. label May 27, 2024
@silvestre silvestre force-pushed the make-api-client-id-configurable branch 3 times, most recently from 0ad3a27 to 2a99337 Compare May 29, 2024 15:59
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@silvestre
Copy link
Member Author

Note, the actual feature is implemented since ages, this just exposes it for configuration.

@silvestre silvestre marked this pull request as ready for review May 29, 2024 16:00
# Issue

As a platform operator you might want to restrict access to the public
API.

# Fix

The property `autoscaler.apiserver.autoscaler_api_client_id`, if set,
restricts the public API endpoint, to only allow requests providing an
oauth token from this client id to access the public API. The token
needs to be provided in the request header `X-Autoscaler-Token`.
@silvestre silvestre force-pushed the make-api-client-id-configurable branch from 2a99337 to f95a994 Compare August 16, 2024 15:14
Copy link

sonarcloud bot commented Aug 16, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant