From 9d9c9af7a7fbb052bd6ef7fd12b5d4ebd20b493e Mon Sep 17 00:00:00 2001 From: Sarkis Varozian Date: Thu, 3 May 2018 16:01:57 -0700 Subject: [PATCH 1/3] delete \n instead of replacing with a , --- bin/helm_toolbox.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/helm_toolbox.sh b/bin/helm_toolbox.sh index c3501842..4d778f9a 100755 --- a/bin/helm_toolbox.sh +++ b/bin/helm_toolbox.sh @@ -21,7 +21,7 @@ function check() { wait_for_helm() { info "Waiting for helm tiller..." while true; do - status=$(kubectl get pods -l app=helm -l name=tiller --show-all=false -o=custom-columns=STATUS:.status.phase --no-headers=true -nkube-system | tr '\n' ',') + status=$(kubectl get pods -l app=helm -l name=tiller --show-all=false -o=custom-columns=STATUS:.status.phase --no-headers=true -nkube-system | tr -d '\n') info "Helm status: $status" if [ "$status" = "Running" ]; then break; From d976035ce04d5cbdbe849f64a720f7701646c1b2 Mon Sep 17 00:00:00 2001 From: Sarkis Varozian Date: Thu, 3 May 2018 16:55:30 -0700 Subject: [PATCH 2/3] cleaner info output with echo --- bin/helm_toolbox.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/helm_toolbox.sh b/bin/helm_toolbox.sh index 4d778f9a..58476c30 100755 --- a/bin/helm_toolbox.sh +++ b/bin/helm_toolbox.sh @@ -21,7 +21,7 @@ function check() { wait_for_helm() { info "Waiting for helm tiller..." while true; do - status=$(kubectl get pods -l app=helm -l name=tiller --show-all=false -o=custom-columns=STATUS:.status.phase --no-headers=true -nkube-system | tr -d '\n') + status=$(echo $(kubectl get pods -l app=helm -l name=tiller --show-all=false -o=custom-columns=STATUS:.status.phase --no-headers=true -nkube-system)) info "Helm status: $status" if [ "$status" = "Running" ]; then break; From 642bea25249c2c16c4d9828458852532aa69a008 Mon Sep 17 00:00:00 2001 From: Sarkis Varozian Date: Thu, 3 May 2018 16:59:33 -0700 Subject: [PATCH 3/3] fix indent --- bin/helm_toolbox.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/helm_toolbox.sh b/bin/helm_toolbox.sh index 58476c30..61849e96 100755 --- a/bin/helm_toolbox.sh +++ b/bin/helm_toolbox.sh @@ -21,7 +21,7 @@ function check() { wait_for_helm() { info "Waiting for helm tiller..." while true; do - status=$(echo $(kubectl get pods -l app=helm -l name=tiller --show-all=false -o=custom-columns=STATUS:.status.phase --no-headers=true -nkube-system)) + status=$(echo $(kubectl get pods -l app=helm -l name=tiller --show-all=false -o=custom-columns=STATUS:.status.phase --no-headers=true -nkube-system)) info "Helm status: $status" if [ "$status" = "Running" ]; then break;