feat: allow providing whitelisted cookie names for ordered_cache_behavior #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rcmorano can you see if you can fix failing checks? Some involve reform and.or running some indicated make targets. |
|
/terratest |
|
Thanks @rcmorano for creating this pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while. While you wait, make sure to review our contributor guidelines. Tip Need help or want to ask for a PR review to be expedited?Join us on Slack in the |
|
/terratest |
|
💥 This pull request now has conflicts. Could you fix it @rcmorano? 🙏 |
|
This PR was closed due to inactivity and merge conflicts. 😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This PR enables the module to provide whitelisted cookie names for ordered cache behaviors.
why
It was possible to provide
allornonefor the cookie forwarding attribute, but it wasn't possible to specifywhitelistalong with a list of cookie names.